linux-kernel - Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 13:36:32 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Mathieu OTHACEHE <m.othacehe@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change
 ti_write_byte function arguments

On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote:
> Remove useless ti_device pointer, and change addr to u32.
> Move function upper to avoid function prototyping.

That's just noise. Having an occasional prototype is just fine. You may
want to consider reordering functions for the first submission, but no
need to move things around after that.

> Also change size variable in function from int to size_t.

Combining changes with moving code, makes it harder to review for no
good reason.

Thanks,
Johan