linux-kernel - Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 23:52:47 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alexandre Bounine <alexandre.bounine@....com>,
	Matt Porter <mporter@...nel.crashing.org>,
	Andre van Herk <andre.van.herk@...drive-technologies.com>,
	Barry Wood <barry.wood@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman <mpe@...erman.id.au> wrote:
>> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
>> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
>
> I'll go out on a limb and assume it's this:
>
> --- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix
> +++ a/arch/powerpc/sysdev/fsl_rio.c
> @@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device
>  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
>  
>  
> -		/* Set to receive any dist ID for serial RapidIO controller. */
> -		if (port->phy_type == RIO_PHY_SERIAL)
> -			out_be32((priv->regs_win
> -				+ RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA);
> -

Yep, thanks.

Hopefully someone somewhere is testing this on powerpc, I don't have one
of those FSL boxes. But at least it will build now.

cheers