linux-kernel - RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3 fix2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2016 19:32:39 +0000
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Matt Porter <mporter@...nel.crashing.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Andre van Herk <andre.van.herk@...drive-technologies.com>,
	"Wood, Barry" <Barry.Wood@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec rev 3
 fix2

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@...ux-foundation.org]
> Sent: Tuesday, August 02, 2016 3:26 PM
> To: Bounine, Alexandre
> Cc: Matt Porter; Michael Ellerman; Andre van Herk; Wood, Barry; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH -next] powerpc/fsl_rio: apply changes for RIO spec
> rev 3 fix2
> 
> On Tue,  2 Aug 2016 14:49:32 -0400 Alexandre Bounine
> <alexandre.bounine@....com> wrote:
> 
> > Fix compile error reported by Michael Ellerman:
> > 		https://lkml.org/lkml/2016/7/27/14
> > also corrects fix: https://lkml.org/lkml/2016/7/27/488
> >
> > --- a/arch/powerpc/sysdev/fsl_rio.c
> > +++ b/arch/powerpc/sysdev/fsl_rio.c
> > @@ -697,6 +697,9 @@ int fsl_rio_setup(struct platform_device *dev)
> >  			((i == 0) ? RIO_INB_ATMU_REGS_PORT1_OFFSET :
> >  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
> >
> > +		/* Set to receive packets with any dest ID */
> > +		out_be32((priv->regs_win + RIO_ISR_AACR + i*0x80),
> > +			 RIO_ISR_AACR_AA);
> >
> >  		/* Configure maintenance transaction window */
> >  		out_be32(&priv->maint_atmu_regs->rowbar,
> 
> Confused.  This doesn't fix a compile error.  I'll assume I just add
> this to https://lkml.org/lkml/2016/7/27/488.

I referenced compile error reported in original Michael's email.

In your patch, write to the register was removed together with port type check. In RIO spec v3 all ports are serial, therefore only the "if" line should be removed with write to the register remaining.