linux-kernel - linux-4.8-rc1/drivers/dma/txx9dmac.c: 2 * pointless expression ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 14:42:46 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	vinod.koul@...el.com, dan.j.williams@...el.com,
	dmaengine@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: linux-4.8-rc1/drivers/dma/txx9dmac.c: 2 * pointless expression ?

Hello there,

1,

linux-4.8-rc1/drivers/dma/txx9dmac.c:751]: (style) Expression '(X &
0x7f) <= 0x7f' is always true.

Source code is

           if (xfer_count > 0x80 &&
                (xfer_count & 0x7f) >= 0x7e &&
                (xfer_count & 0x7f) <= 0x7f)

2.

inux-4.8-rc1/drivers/dma/txx9dmac.c:746]: (style) Expression '(X &
0xff) <= 0xff' is always true.

Duplicate, a few lines earlier.

Regards

David Binderman