linux-kernel - Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 15:43:15 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	dirk.eibach@...ys.cc
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	jslaby@...e.com, jringle@...dpoint.com
Subject: Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@...ys.cc wrote:
> From: Dirk Eibach <dirk.eibach@...ys.cc>
> 
> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only
> when there is no more interrupt left to service. This not common
> practice.
> In our case it lead to some strange hangup situation when there was an
> unexpected XOFF-interrupt that could not be handled.
> So let's service interrupts only once and report XOFF-interrupts that
> should never happen since they are never enabled.
> 
> Signed-off-by: Dirk Eibach <dirk.eibach@...ys.cc>
> 
> Conflicts:
> 	drivers/tty/serial/sc16is7xx.c

Why are these 2 lines in here?