linux-kernel - Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2016 07:44:59 -0700
From:   Sören Brinkmann <soren.brinkmann@...inx.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        Marc Zyngier <marc.zyngier@....com>, <monstr@...str.eu>,
        <ralf@...ux-mips.org>, <jason@...edaemon.net>,
        <alistair@...ple.id.au>, <mporter@...nel.crashing.org>,
        <linux-kernel@...r.kernel.org>, <linux-mips@...ux-mips.org>,
        <michal.simek@...inx.com>, <linuxppc-dev@...ts.ozlabs.org>,
        <mpe@...erman.id.au>, <paulus@...ba.org>,
        <benh@...nel.crashing.org>
Subject: Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote:
> On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote:
> > On 10/21/2016 10:48 AM, Marc Zyngier wrote:
> > > Shouldn't you return an error if irq is zero?
> > > 
> > 
> > I'll add the following for the error case
> > 
> > 	pr_err("%s: Parent exists but interrupts property not defined\n" ,
> > __func__);
> 
> Please do not use this silly __func__ stuff. It's not giving any value to
> the printout.
> 
> Set a proper prefix for your pr_* stuff, so the string is prefixed with
> 'irq-xilinx:' or whatever you think is appropriate. Then the string itself
> is good enough to find from which place this printk comes.

Haven't looked at the real code, but is there probably a way to get a
struct device pointer and use dev_err?

	Sören