linux-kernel - RE: [PATCH V2 3/4] regulator: pv88080: Update Regulator driver for MFD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2016 05:59:41 +0000
From:   Eric Hyeung Dong Jeong <eric.jeong.opensource@...semi.com>
To:     Mark Brown <broonie@...nel.org>,
        Eric Hyeung Dong Jeong <eric.jeong.opensource@...semi.com>
CC:     LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Alexandre Courbot <gnurou@...il.com>,
        DEVICETREE <devicetree@...r.kernel.org>,
        LINUX-GPIO <linux-gpio@...r.kernel.org>,
        "Lee Jones" <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        "Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [PATCH V2 3/4] regulator: pv88080: Update Regulator driver for
 MFD support

On Thursday, October 27, 2016 8:04 PM, Mark Brown wrote:

> On Thu, Oct 27, 2016 at 10:03:14AM +0900, Eric Jeong wrote:
> 
> >  config REGULATOR_PV88080
> > -	tristate "Powerventure Semiconductor PV88080 regulator"
> > -	depends on I2C
> > -	select REGMAP_I2C
> > +	bool "Powerventure Semiconductor PV88080 regulator"
> > +	depends on MFD_PV88080
> 
> Forcing the driver to be built in looks like a regression, why would we want to
> do that?
> 
> > +	irq = platform_get_irq_byname(pdev, "regulator-irq");
> > +	if (irq < 0) {
> > +		dev_err(&pdev->dev, "Failed to get IRQ.\n");
> > +		return irq;
> >  	}
> 
> What's the _byname() adding here given that the name is so generic?  It feels
> like if the name ever becomes important then this particular name is going to
> be a problem.
> 
> > -module_i2c_driver(pv88080_regulator_driver);
> > +static int __init pv88080_regulator_init(void) {
> > +	return platform_driver_register(&pv88080_regulator_driver);
> > +}
> > +subsys_initcall(pv88080_regulator_init);
> 
> Why are you converting this to subsys_initcall()?  This looks like another
> regression.

Thank you for the comments.
There was an internal request to release driver based on Kernel 3.18 for GPIO and MFD support.
After that, the code has been kept. I will send a patch again after changes.

Regards
Eric