linux-kernel - [PATCH] drm/armada: Fix NULL pointer comparison warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 08 Nov 2016 11:30:09 +0530
From:   Ravikant Bijendra Sharma <ravikant.s2@...sung.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        David Airlie <airlied@...ux.ie>
Cc:     dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org,
        Ravikant Bijendra Sharma <ravikant.s2@...sung.com>,
        shailesh pandey <p.shailesh@...sung.com>,
        vidushi.koul@...sung.com, linux-kernel@...r.kernel.org
Subject: [PATCH] drm/armada: Fix NULL pointer comparison warning

From: Ravikant B Sharma <ravikant.s2@...sung.com>

Replace direct comparisons to NULL i.e.
'x == NULL' with '!x'. As per coding standard.

Signed-off-by: Ravikant B Sharma <ravikant.s2@...sung.com>
---
 drivers/gpu/drm/armada/armada_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index d4f7ab0..90222e6 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -113,7 +113,7 @@ static int drm_add_fake_info_node(struct drm_minor *minor, struct dentry *ent,
 	struct drm_info_node *node;
 
 	node = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
-	if (node == NULL) {
+	if (!node) {
 		debugfs_remove(ent);
 		return -ENOMEM;
 	}
-- 
1.7.9.5