linux-kernel - RE: [patch v5] i2c: mux: mellanox: add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2016 13:04:52 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Peter Rosin <peda@...ntia.se>,
        "wsa@...-dreams.de" <wsa@...-dreams.de>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        Michael Shych <michaelsh@...lanox.com>
Subject: RE: [patch v5] i2c: mux: mellanox: add driver



> -----Original Message-----
> From: Peter Rosin [mailto:peda@...ntia.se]
> Sent: Thursday, November 10, 2016 3:02 PM
> To: Vadim Pasternak <vadimp@...lanox.com>; wsa@...-dreams.de
> Cc: linux-i2c@...r.kernel.org; linux-kernel@...r.kernel.org; jiri@...nulli.us;
> Michael Shych <michaelsh@...lanox.com>
> Subject: Re: [patch v5] i2c: mux: mellanox: add driver
> 
> On 2016-11-10 13:56, Vadim Pasternak wrote:
> >
> >
> >> -----Original Message-----
> >> From: Peter Rosin [mailto:peda@...ntia.se]
> >> Sent: Thursday, November 10, 2016 1:13 PM
> >> To: Vadim Pasternak <vadimp@...lanox.com>; wsa@...-dreams.de
> >> Cc: linux-i2c@...r.kernel.org; linux-kernel@...r.kernel.org;
> >> jiri@...nulli.us; Michael Shych <michaelsh@...lanox.com>
> >> Subject: Re: [patch v5] i2c: mux: mellanox: add driver
> >>
> >> [resend to all, got the wrong button, sorry]
> >>
> >> On 2016-11-10 11:42, Peter Rosin wrote:
> >>> On 2016-11-03 06:20, Vadim Pasternak wrote:
> >>>> Hi,
> >>>>
> >>>> I see that this patch has not been picked-up yet for i2c-next.
> >>>> Is it possible it was missed from some reason?
> >>>
> >>> Yes, apparently, really sorry about that!
> >>>
> >>> I'll put it in a branch and make a pull request for Wolfram (but
> >>> that is a bit new for me, we'll see how it goes).
> >>
> >> But now that I looked again, I noticed that the source is dual
> >> licensed and yet your MODULE_LICENSE tag says only "GPL v2". I.e. the
> >> same issue your i2c master driver had that Vladimir Zapolskiy noticed.
> >>
> >> Please fix this, and it might be a good idea to take a look in your
> >> other drivers as well in case you have further problems in this department...
> >
> > Hi Peter,
> >
> > Thank you for reply.
> > I'll re-submit it from the current i2c next branch.
> > Since I'll fix the license, I guess I should issue it as "patch v6". Right?
> 
> Sounds right, yes.

OK, will do it.
And I'll fix the comment according to your last recommendation.

Cheers,
Vadim.
> 
> Cheers,
> Peter