linux-kernel - Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Jan 2017 11:57:21 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kartikey Singh <dr.kartikeynrc@...il.com>
Cc:     insafonov@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary
 defined macros

On Sun, Jan 15, 2017 at 01:09:23PM +0530, Kartikey Singh wrote:
> Removed macros not in use.
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@...il.com>
> ---
>  drivers/staging/rtl8188eu/include/wifi.h | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h
> index 9e08e68..9c9c334 100644
> --- a/drivers/staging/rtl8188eu/include/wifi.h
> +++ b/drivers/staging/rtl8188eu/include/wifi.h
> @@ -480,15 +480,6 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe)
>  				Below is the definition for 802.11n
>  ------------------------------------------------------------------------------*/
>  
> -#define SetOrderBit(pbuf)	\
> -	do	{	\
> -		*(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_); \
> -	} while (0)
> -
> -#define GetOrderBit(pbuf)			\
> -	(((*(unsigned short *)(pbuf)) & le16_to_cpu(_ORDER_)) != 0)
> -
> -

That's good, but:

>  /**
>   * struct rtw_ieee80211_bar - HT Block Ack Request
>   *
> @@ -758,6 +749,8 @@ enum ht_cap_ampdu_factor {
>  #define	P2P_STATUS_FAIL_USER_REJECT			0x0B
>  
>  /*	Value of Invitation Flags Attribute */
> +
> +/*
>  #define	P2P_INVITATION_FLAGS_PERSISTENT			BIT(0)
>  
>  #define	DMP_P2P_DEVCAP_SUPPORT	(P2P_DEVCAP_SERVICE_DISCOVERY | \
> @@ -766,6 +759,7 @@ enum ht_cap_ampdu_factor {
>  				P2P_DEVCAP_INVITATION_PROC)
>  
>  #define	DMP_P2P_GRPCAP_SUPPORT	(P2P_GRPCAP_INTRABSS)
> +*/

Why did you comment these out and not just remove them?

No need keeping around useless stuff, right?

thanks,

greg k-h