linux-kernel - Re: spidev: Adjust five checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 16:34:45 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-spi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: spidev: Adjust five checks for null pointers

>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
> 
> Please fix however you're sending things out to avoid this noise.

The Git software generated such extra information because my commit message
contained a few special characters.


>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
> 
> This changelog does not describe any purpose in making this change,
> we could equally well say the exact opposite.  Why should we do this?

How do you think about to reduce the usage of the preprocessor symbol “NULL”?

Can it help if the source code is a little bit shorter after the
proposed adjustment?

Regards,
Markus