linux-kernel - Re: spidev: Adjust five checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 13:33:59 +0100
From:   Mark Brown <broonie@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-spi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: spidev: Adjust five checks for null pointers

On Thu, May 18, 2017 at 04:34:45PM +0200, SF Markus Elfring wrote:

> >> The script “checkpatch.pl” pointed information out like the following.

> >> Comparison to NULL could be written !…

> >> Thus fix the affected source code places.

> > This changelog does not describe any purpose in making this change,
> > we could equally well say the exact opposite.  Why should we do this?

> How do you think about to reduce the usage of the preprocessor symbol “NULL”?

Why would that matter?

> Can it help if the source code is a little bit shorter after the
> proposed adjustment?

Not really - clarity is important but the size of code isn't too
meaningful in and of itself.

Please if you don't really understand what you're sending try to
understand it first, don't throw things out without that.  I know a
number of other maintainers have already raised concerns about the
quality of what's being sent and the effort required to review them in
relation to their value.  There's nothing wrong with doing small
cleanups but if that's all you're sending and there's often problems
then it becomes more trouble than it's worth to review your changes.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)