linux-kernel - Re: [PATCH RESEND] fbdev: omapfb: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 16:27:30 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     dri-devel@...ts.freedesktop.org,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] fbdev: omapfb: remove unused variable


Hi,

On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
> Removing the default display name left a harmless warning:
> 
> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
> 
> This removes the now-unused variable as well.
> 
> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> Originally submitted on June 9, no reply other than the Reviewed-by tag.
> The patch is still needed

It is not lost and will be queued for 4.13 fbdev fixes pull request.

[ The guilty commit went through DRM tree and pulling it into fbdev
  tree just to fix the warning was not feasible.. ]

> ---
>  drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> index eecf695c16f4..09e5bb013d28 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
>  
>  static int __init omap_dss_probe(struct platform_device *pdev)
>  {
> -	struct omap_dss_board_info *pdata = pdev->dev.platform_data;
>  	int r;
>  
>  	core.pdev = pdev;

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics