linux-kernel - Re: [PATCH RESEND] fbdev: omapfb: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 16:31:38 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] fbdev: omapfb: remove unused variable

On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@...sung.com> wrote:
>
> Hi,
>
> On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
>> Removing the default display name left a harmless warning:
>>
>> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
>> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
>>
>> This removes the now-unused variable as well.
>>
>> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>> ---
>> Originally submitted on June 9, no reply other than the Reviewed-by tag.
>> The patch is still needed
>
> It is not lost and will be queued for 4.13 fbdev fixes pull request.

Ok, thanks a lot!

> [ The guilty commit went through DRM tree and pulling it into fbdev
>   tree just to fix the warning was not feasible.. ]

Yes, I was originally hoping the fix could be merged along with the
patch that introduced the bug. I may have messed up the Cc list for that
though.

       Arnd