linux-kernel - Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

Open Source and information security mailing list archives

Date:   Thu, 27 Jul 2017 21:43:31 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Rex Zhu <Rex.Zhu@....com>,
        Christian König <christian.koenig@....com>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook <keescook@...omium.org> wrote:
> As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use
> designated initializers") mark other tableFunction entries with designated
> initializers. The randstruct plugin requires designated initializers for
> structures that are entirely function pointers.
>
> Cc: Rex Zhu <Rex.Zhu@....com>
> Cc: Hawking Zhang <Hawking.Zhang@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> If I can get an Ack for this, I'll carry it in the gcc-plugins tree, unless
> you think this is worth landing for v4.13, in which case, please take it
> now. :)
>

Acked-by: Alex Deucher <alexander.deucher@....com>

I'm happy to take this through my tree if that is ok with you.

Alex

> Thanks!
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> index 4c7f430b36eb..8e6cfd89c7e0 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
> @@ -308,8 +308,8 @@ static int rv_tf_set_num_active_display(struct pp_hwmgr *hwmgr, void *input,
>  }
>
>  static const struct phm_master_table_item rv_set_power_state_list[] = {
> -       { NULL, rv_tf_set_clock_limit },
> -       { NULL, rv_tf_set_num_active_display },
> +       { .tableFunction = rv_tf_set_clock_limit },
> +       { .tableFunction = rv_tf_set_num_active_display },
>         { }
>  };
>
> @@ -382,7 +382,7 @@ static int rv_tf_disable_gfx_off(struct pp_hwmgr *hwmgr,
>  }
>
>  static const struct phm_master_table_item rv_disable_dpm_list[] = {
> -       {NULL, rv_tf_disable_gfx_off},
> +       { .tableFunction = rv_tf_disable_gfx_off },
>         { },
>  };
>
> @@ -407,7 +407,7 @@ static int rv_tf_enable_gfx_off(struct pp_hwmgr *hwmgr,
>  }
>
>  static const struct phm_master_table_item rv_enable_dpm_list[] = {
> -       {NULL, rv_tf_enable_gfx_off},
> +       { .tableFunction = rv_tf_enable_gfx_off },
>         { },
>  };
>
> --
> 2.7.4
>
>
> --
> Kees Cook
> Pixel Security
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives