linux-kernel - Re: [RFC PATCH 4/8] seq_buf: Add seq_buf_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2017 21:43:29 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-edac <linux-edac@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>,
        Yazen Ghannam <Yazen.Ghannam@....com>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 4/8] seq_buf: Add seq_buf_clear_buf()

On Tue, 25 Jul 2017 17:45:57 +0200
Borislav Petkov <bp@...en8.de> wrote:

> From: Borislav Petkov <bp@...e.de>
> 
> This is the version which clears the supplied buffer too. Useful when
> we're done with the buffer and want to clean it up and prepare it for
> reuse.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Steven Rostedt <rostedt@...dmis.org>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> ---
>  include/linux/seq_buf.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h
> index fb7eb9ccb1cd..8705a482e76c 100644
> --- a/include/linux/seq_buf.h
> +++ b/include/linux/seq_buf.h
> @@ -28,6 +28,13 @@ static inline void seq_buf_clear(struct seq_buf *s)
>  	s->readpos = 0;
>  }
>  
> +/* Like seq_buf_clear() but zero out the buffer too. */
> +static inline void seq_buf_clear_buf(struct seq_buf *s)
> +{
> +	seq_buf_clear(s);
> +	memset(s->buffer, 0, s->size);
> +}
> +
>  static inline void
>  seq_buf_init(struct seq_buf *s, unsigned char *buf, unsigned int size)
>  {