[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 10 Oct 2017 15:35:51 +0800
From: Chaotian Jing <chaotian.jing@...iatek.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
CC: Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
yong mao <yong.mao@...iatek.com>,
Linus Walleij <linus.walleij@...aro.org>,
"Heiner Kallweit" <hkallweit1@...il.com>,
Phong LE <ple@...libre.com>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
srv_heupstream <srv_heupstream@...iatek.com>
Subject: Re: [PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712
On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote:
> [...]
>
> > +
> > +static const struct of_device_id msdc_of_ids[] = {
> > + { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
> > + { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
> > + { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat},
> > + { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat},
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(of, msdc_of_ids);
>
> As already stated in the other reply. These new compatible changes
> needs to be discussed and acked before the driver starts using them.
>
> In other words, make patch3 to precede this one.
but, then there will have a probe issue as mentioned in previous mail
list. that's why I separate the binding file changes to 2 patches.
>
> [...]
>
> Kind regards
> Uffe
Powered by blists - more mailing lists