linux-kernel - Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 17:40:28 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Keith Packard <keithp@...thp.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dave Airlie <airlied@...hat.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object
 leases [v4]

> +                */
> +               ret = idr_alloc(&leases, &drm_lease_idr_object , object_id, object_id + 1, GFP_KERNEL);

In current kernels, the idr_alloc warns if start < 0, so if object_id
is a negative signed integer, which your
igt tests actually make it.

So we get an ugly debug splat from the idr code, you should probably
make sure object_id is
something valid in signed space first, to avoid the splat.

Dave.