linux-kernel - Re: [PATCH] nullb: make config_item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2017 08:47:43 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>, shli@...com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nullb: make config_item_type const

On 10/12/2017 08:42 AM, Bhumika Goyal wrote:
> On Thu, Oct 12, 2017 at 4:27 PM, Jens Axboe <axboe@...nel.dk> wrote:
>> On 10/12/2017 04:19 AM, Bhumika Goyal wrote:
>>> This is a followup patch for: https://lkml.org/lkml/2017/10/11/375 and
>>> https://patchwork.kernel.org/patch/9999649/
>>>
>>> Make these structures const as they are either passed to the functions
>>> having the argument as const or stored as a reference in the "ci_type"
>>> const field of a config_item structure.
>>
>> Thanks, applied.
>>
> 
> Hello,
> 
> Actually, this patch is dependent on the patches in the links
> https://lkml.org/lkml/2017/10/11/375 and
> https://patchwork.kernel.org/patch/9999649/. Therefore, this patch
> won't be correct unless the patches in these links gets applied.

Gah, I do see that now. That should have been made much clearer in
the patch description!

When you send out patches with hard dependencies like that, either
wait until the dependency has been solved in mainline, or make it
explicitly clear in the patch submission.

-- 
Jens Axboe