linux-kernel - [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 20:38:28 +0100
From:   Stefano Manni <stefano.manni@...il.com>
To:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, stefano.manni@...il.com
Subject: [PATCH 1/4] staging: lustre: fixed signedness of some socklnd params

sparse warnings:
warning: incorrect type in assignment (different signedness)
expected int *[addressable] [toplevel] [assigned] ksnd_nscheds
got unsigned int static [toplevel] *<noident>
warning: incorrect type in assignment (different signedness)
expected int *[addressable] [toplevel] [assigned] ksnd_zc_recv
got unsigned int static [toplevel] *<noident>
warning: incorrect type in assignment (different signedness)
expected int *[addressable] [toplevel] [assigned] ksnd_zc_recv_min_nfrags
got unsigned int static [toplevel] *<noident>

Signed-off-by: Stefano Manni <stefano.manni@...il.com>
---
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h           | 4 ++--
 drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
index d50ebdf..474f93a 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
@@ -158,10 +158,10 @@ struct ksock_tunables {
 	unsigned int *ksnd_zc_min_payload;     /* minimum zero copy payload
 						* size
 						*/
-	int          *ksnd_zc_recv;            /* enable ZC receive (for
+	unsigned int *ksnd_zc_recv;            /* enable ZC receive (for
 						* Chelsio TOE)
 						*/
-	int          *ksnd_zc_recv_min_nfrags; /* minimum # of fragments to
+	unsigned int *ksnd_zc_recv_min_nfrags; /* minimum # of fragments to
 						* enable ZC receive
 						*/
 };
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
index 5663a4c..2ad89ca 100644
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_modparams.c
@@ -43,7 +43,7 @@ MODULE_PARM_DESC(peer_timeout, "Seconds without aliveness news to declare peer d
  * Number of daemons in each thread pool which is percpt,
  * we will estimate reasonable value based on CPUs if it's not set.
  */
-static unsigned int nscheds;
+static int nscheds;
 module_param(nscheds, int, 0444);
 MODULE_PARM_DESC(nscheds, "# scheduler daemons in each pool while starting");
 
-- 
2.5.5