linux-kernel - [PATCH 2/4] staging: lustre: fixed signedness of llite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2017 20:38:29 +0100
From:   Stefano Manni <stefano.manni@...il.com>
To:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, stefano.manni@...il.com
Subject: [PATCH 2/4] staging: lustre: fixed signedness of llite

sparse warnings on dir.c:
warning: incorrect type in argument 5 (different signedness)
expected unsigned int [usertype] *vallen
got int *<noident>

sparse warnings on llite_lib.c:
warning: incorrect type in argument 5 (different signedness)
expected unsigned int [usertype] *vallen
got int *<noident>

sparse warnings on lproc_llite.c:
warning: incorrect type in argument 2 (different signedness)
expected int *max_mdsize
got unsigned int *<noident>
warning: incorrect type in argument 2 (different signedness)
expected int *default_mdsize
got unsigned int *<noident>
warning: incorrect type in initializer (different signedness)
expected int *off_count
got unsigned int *<noident>
warning: incorrect type in initializer (different signedness)
expected int *process_count
got unsigned int *<noident>

Signed-off-by: Stefano Manni <stefano.manni@...il.com>
---
 drivers/staging/lustre/lustre/llite/dir.c         |  3 ++-
 drivers/staging/lustre/lustre/llite/llite_lib.c   |  9 ++++++---
 drivers/staging/lustre/lustre/llite/lproc_llite.c | 14 ++++++--------
 3 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 5b2e47c..ee6e8ef 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1422,7 +1422,8 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case LL_IOC_FLUSHCTX:
 		return ll_flush_ctx(inode);
 	case LL_IOC_GETOBDCOUNT: {
-		int count, vallen;
+		int count;
+		unsigned int vallen;
 		struct obd_export *exp;
 
 		if (copy_from_user(&count, (int __user *)arg, sizeof(int)))
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 8666f1e..6f82bff 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -159,7 +159,8 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
 	struct md_op_data *op_data;
 	struct lustre_md lmd;
 	u64 valid;
-	int size, err, checksum;
+	int err, checksum;
+	unsigned int size;
 
 	obd = class_name2obd(md);
 	if (!obd) {
@@ -571,7 +572,8 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
 
 int ll_get_max_mdsize(struct ll_sb_info *sbi, int *lmmsize)
 {
-	int size, rc;
+	int rc;
+	unsigned int size;
 
 	size = sizeof(*lmmsize);
 	rc = obd_get_info(NULL, sbi->ll_dt_exp, sizeof(KEY_MAX_EASIZE),
@@ -604,7 +606,8 @@ int ll_get_max_mdsize(struct ll_sb_info *sbi, int *lmmsize)
  */
 int ll_get_default_mdsize(struct ll_sb_info *sbi, int *lmmsize)
 {
-	int size, rc;
+	int rc;
+	unsigned int size;
 
 	size = sizeof(int);
 	rc = obd_get_info(NULL, sbi->ll_md_exp, sizeof(KEY_DEFAULT_EASIZE),
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c
index 644bea2..52dbd56 100644
--- a/drivers/staging/lustre/lustre/llite/lproc_llite.c
+++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c
@@ -734,14 +734,13 @@ static ssize_t max_easize_show(struct kobject *kobj,
 {
 	struct ll_sb_info *sbi = container_of(kobj, struct ll_sb_info,
 					      ll_kobj);
-	unsigned int ealen;
-	int rc;
+	int rc, ealen;
 
 	rc = ll_get_max_mdsize(sbi, &ealen);
 	if (rc)
 		return rc;
 
-	return sprintf(buf, "%u\n", ealen);
+	return sprintf(buf, "%d\n", ealen);
 }
 LUSTRE_RO_ATTR(max_easize);
 
@@ -763,14 +762,13 @@ static ssize_t default_easize_show(struct kobject *kobj,
 {
 	struct ll_sb_info *sbi = container_of(kobj, struct ll_sb_info,
 					      ll_kobj);
-	unsigned int ealen;
-	int rc;
+	int rc, ealen;
 
 	rc = ll_get_default_mdsize(sbi, &ealen);
 	if (rc)
 		return rc;
 
-	return sprintf(buf, "%u\n", ealen);
+	return sprintf(buf, "%d\n", ealen);
 }
 
 /**
@@ -1479,8 +1477,8 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
 	int i, cur = -1;
 	struct ll_rw_process_info *process;
 	struct ll_rw_process_info *offset;
-	int *off_count = &sbi->ll_rw_offset_entry_count;
-	int *process_count = &sbi->ll_offset_process_count;
+	unsigned int *off_count = &sbi->ll_rw_offset_entry_count;
+	unsigned int *process_count = &sbi->ll_offset_process_count;
 	struct ll_rw_extents_info *io_extents = &sbi->ll_rw_extents_info;
 
 	if (!sbi->ll_rw_stats_on)
-- 
2.5.5