linux-kernel - Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 16:08:45 +0100
From:   Lukas Senger <lukas@...dolin.com>
To:     Rodolfo Giometti <giometti@...eenne.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree

> > @@ -20,18 +21,20 @@
> >   		target = <&gpio>;
> >   		__overlay__ {
> >   			pps_pins: pps_pins@12 {
> > -				brcm,pins =     <18>;
> > -				brcm,function = <0>;    // in
> > -				brcm,pull =     <0>;    // off
> > +				brcm,pins =     <18 17>;
> > +				brcm,function = <0 1>;    // in
> > out
> > +				brcm,pull =     <0 0>;    // off
> > off  
> 
> These modifications are not PPS related.
> 
> >   			};
> >   		};
> >   	};
> >   
> >   	__overrides__ {
> > -		gpiopin = <&pps>,"gpios:4",
> > +		gpiopin = <&pps>,"in-gpios:4",
> >   			  <&pps>,"reg:0",
> >   			  <&pps_pins>,"brcm,pins:0",
> >   			  <&pps_pins>,"reg:0";
> > +		echopin = <&pps>,"out-gpios:4",
> > +			  <&pps_pins>,"brcm,pins:4";  
> 
> Ditto.

I don't understand why these modifications are unrelated. Especially
the echopin-option should exist, shouldn't it?

Cheers,
Lukas