linux-kernel - Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Feb 2018 16:12:38 +0100
From:   Lukas Senger <lukas@...dolin.com>
To:     Rodolfo Giometti <giometti@...eenne.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog

> Why a void function? You should use it to toggle echoing GPIO... =8-o

RFC 2783 says to generate the echo pulse "as rapidly as possible" which
is why I do the toggling in the irq handler. However this leaves the
default echo function installed which just floods syslog.

Another problem with this patch is that it also is against my old one
and not against current kernel code.

Cheers,
Lukas