linux-kernel - Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Feb 2018 11:39:01 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

On Wed, Feb 14, 2018 at 11:07:39PM +0100, Sebastian Reichel wrote:

> +config SND_SOC_CPCAP
> +	tristate "Motorola CPCAP codec"
> +	depends on MFD_CPCAP
> +	default MFD_CPCAP
> +

We don't have default lines like this for other MFDs...

> +	SOC_ENUM("Hifi Left Phase Playback Switch",
> +		cpcap_hifi_l_phase_inv_enum),
> +	SOC_ENUM("Ext Left Phase Playback Switch",
> +		cpcap_ext_l_phase_inv_enum),

If this is a Switch control it should be a simple on/off binary control.
If it's an enumeration it shouldn't have Switch at the end of the name
since that's a keyword interpreted by userspace.  Either option seems
fine in this case, if it's a switch it should be "Foo Invert Switch" or
similar.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)