linux-kernel - Re: [PATCH] Update rf_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Mar 2018 12:43:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     l4stpr0gr4m@...il.com
Cc:     justin@...eeland.com, hdegoede@...hat.com, hadess@...ess.net,
        colin.king@...onical.com, Larry.Finger@...inger.net,
        aishpant@...il.com, himanshujha199640@...il.com, arnd@...db.de,
        ianwmorrison@...il.com, davem@...emloft.net, joe@...ches.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Update rf_type_definition

On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0gr4m@...il.com wrote:
> From: Kangmin Park <l4stpr0gr4m@...il.com>

Your subject line should say the subsystem and driver you are modifying.
Look at the hundreds of other patches on the mailing lists for examples
of how to properly format it.

> 
> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
> 
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
> 
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
> 
> Also, fixed some space required errors and
> line over 80 characters warnings by checkpatch.pl.

When you say "also", that means you should be splitting this patch up
into multpile patches.  Please only do one-thing-per-patch.

This should be a patch series, please fix it up and resend.

thanks,

greg k-h