linux-kernel - Re: [PATCH] MIPS: ralink: remove ralink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Mar 2018 23:52:50 +0000
From:   James Hogan <jhogan@...nel.org>
To:     NeilBrown <neil@...wn.name>
Cc:     John Crispin <john@...ozen.org>,
        Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: ralink: remove ralink_halt()

On Tue, Mar 20, 2018 at 07:29:51PM +1100, NeilBrown wrote:
> 
> ralink_halt() does nothing that machine_halt()
> doesn't already do, so it adds no value.
> 
> It actually causes incorrect behaviour due to the
> "unreachable()" at the end.  This tell the compiler that the
> end of the function will never be reached, which isn't true.
> The compiler responds by not adding a 'return' instruction,
> so control simply moves on to whatever bytes come afterwards
> in memory.  In my tested, that was the ralink_restart()
> function.  This means that an attempt to 'halt' the machine
> would actually cause a reboot.
> 
> So remove ralink_halt() so that a 'halt' really does halt.
> 
> Signed-off-by: NeilBrown <neil@...wn.name>

Thanks, I've cosmetically tweaked the commit message (mainly reflow to
72 characters) and added:

Fixes: c06e836ada59 ("MIPS: ralink: adds reset code")
Cc: <stable@...r.kernel.org> # 3.9+

and applied for 4.16.

BTW, I'm intrigued to know if there's a particular reason you don't
author / sign-off as "Neil Brown"? Its supposed to be real names, though
"NeilBrown" is hardly difficult to figure out so I don't actually
object.

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)