linux-kernel - Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 02 Apr 2018 07:57:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     devel@...verdev.osuosl.org, wsa@...-dreams.de,
        gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, Quytelda Kahja <quytelda@...alin.org>
Subject: Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to
 calculate array sizes.

On Mon, 2018-04-02 at 14:45 +0300, Dan Carpenter wrote:
> On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote:
> > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote:
> > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > > > > This macro, provided in 'linux/kernel.h', will calculate the size
> > > > > more succinctly than a division operation.
> > > > 
> > > > It's nice that you send patches, but please try to send a
> > > > cover letter with your patch series.
> > > > 
> > > 
> > > There are obviously times when a cover letter is required but what's the
> > > point of that for this particular series?
> > 
> > practice
> > 
> It really pisses me off to see patch submitters get assign busy work
> for no reason.  This is not school and these are not your students.

Please take a chill pill Dan.
I think cover letters are best practice.