linux-kernel - Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 09 Apr 2018 20:42:32 +0000
From:   Evan Green <evgreen@...omium.org>
To:     swboyd@...omium.org
Cc:     Lina Iyer <ilina@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-kernel@...r.kernel.org,
        Doug Anderson <dianders@...omium.org>,
        devicetree@...r.kernel.org, msivasub@...eaurora.org
Subject: Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for
 QCOM SoCs

On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd <swboyd@...omium.org> wrote:

> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian <msivasub@...eaurora.org>
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicetree@...r.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian <msivasub@...eaurora.org>
> > Signed-off-by: Lina Iyer <ilina@...eaurora.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > ---
> >

> Reviewed-by: Stephen Boyd <swboyd@...omium.org>

> > +       reserved-memory {
> > +               [...]
> > +               qcom,cmd-db@...e0000 {

> Nitpick: This may want to be called 'memory@...e0000' because we prefer
> generic node names.

Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.

Reviewed-by: Evan Green <evgreen@...omium.org>

-Evan