linux-kernel - Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Apr 2018 07:07:51 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Gabriel Francisco Mandaji <gfmandaji@...il.com>
cc:     gregkh@...uxfoundation.org, abbotti@....co.uk,
        hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function
 parameters



On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:

> Fix most checkpatch.pl issues of type:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gabriel Francisco Mandaji <gfmandaji@...il.com>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index fdd81c3..631a703 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
>  }
>
>  static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
> -					const struct comedi_cmd *cmd)
> +				   const struct comedi_cmd *cmd)

Someone has made the effort to put const on these parameters, but not on
the other similar functions.  Perhaps this can be improved as well.

julia

>  {
>  	/* supposed to load counter with desired divisor minus 3 */
>  	return cmd->convert_arg / TIMER_BASE - 3;
>  }
>
>  static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
> -				     struct comedi_cmd *cmd)
> +				struct comedi_cmd *cmd)
>  {
>  	u32 count;
>
> @@ -2296,7 +2296,7 @@ static u32 ai_scan_counter_6xxx(struct comedi_device *dev,
>  }
>
>  static u32 ai_convert_counter_4020(struct comedi_device *dev,
> -					struct comedi_cmd *cmd)
> +				   struct comedi_cmd *cmd)
>  {
>  	struct pcidas64_private *devpriv = dev->private;
>  	unsigned int divisor;
> --
> 1.9.1
>
>