linux-kernel - Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Apr 2018 10:16:22 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Gabriel Francisco Mandaji <gfmandaji@...il.com>
Cc:     gregkh@...uxfoundation.org, hsweeten@...ionengravers.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        lkcamp@...ts.libreplanetbr.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function
 parameters

On 11/04/18 06:07, Julia Lawall wrote:
> On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
[snip]
>> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> index fdd81c3..631a703 100644
>> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
>> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
>> @@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
>>   }
>>
>>   static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
>> -					const struct comedi_cmd *cmd)
>> +				   const struct comedi_cmd *cmd)
> 
> Someone has made the effort to put const on these parameters, but not on
> the other similar functions.  Perhaps this can be improved as well.

Perhaps, but that should be in a separate patch.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-