linux-kernel - Re: [PATCH] crypto: testmgr: add test vectors for skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 07:12:47 +0900
From:   Juan Manuel Torres Palma <j.m.torrespalma@...il.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein

On Wed, Jun 20, 2018 at 11:10:51AM -0700, Eric Biggers wrote:
> Also, can you describe the users of Skein in the kernel?  If there are no users,
> there's no need to move it out of staging, or even have it in the kernel at all
> anymore.  I say that as someone who has had to volunteer to fix critical bugs
> found by fuzzing in crypto algorithms for which it's unclear why they are in the
> kernel at all, as there are no apparent users.

To be honest I'm not aware of anyone actually using Skein.

So by this are you suggesting that we drop support? If not removed, I believe
it's better to use test vectors as regression tests for further modifications.

-- 
Juan Manuel Torres Palma
Computer Engineer