linux-kernel - Re: [PATCH] crypto: testmgr: add test vectors for skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 20:26:34 +0200
From:   Stephan Mueller <smueller@...onox.de>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     Juan Manuel Torres Palma <j.m.torrespalma@...il.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein

Am Mittwoch, 20. Juni 2018, 19:56:38 CEST schrieb Eric Biggers:

Hi Eric,

> > +		.alg = "skein1024",
> > +		.test = alg_test_hash,
> > +		.fips_allowed = 1,
> 
> Are you sure Skein should be on the "FIPS allowed" list?  I'm not
> particularly familiar with FIPS, but my understanding is that the
> fips_allowed flag is only supposed to be set on specific "approved"
> algorithms.  So if you're unsure, it shouldn't be set.

Skein is definitely not allowed in FIPS mode. Please drop that flag.
> 
> Eric



Ciao
Stephan