linux-kernel - Re: [PATCH] crypto: testmgr: add test vectors for skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 11:10:51 -0700
From:   Eric Biggers <ebiggers3@...il.com>
To:     Juan Manuel Torres Palma <j.m.torrespalma@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein

On Wed, Jun 20, 2018 at 07:57:14PM +0900, Juan Manuel Torres Palma wrote:
> Adds test vectors specified in skein v1.3
> specification. The main code is still in staging
> directory, but this is required to eventually be
> moved to the crypto directory.

Also, can you describe the users of Skein in the kernel?  If there are no users,
there's no need to move it out of staging, or even have it in the kernel at all
anymore.  I say that as someone who has had to volunteer to fix critical bugs
found by fuzzing in crypto algorithms for which it's unclear why they are in the
kernel at all, as there are no apparent users.

By the way, syzbot [1] doesn't have CONFIG_CRYPTO_SKEIN enabled, so the Skein
algorithms aren't being fuzzed currently.

[1] https://github.com/google/syzkaller/blob/master/docs/syzbot.md

- Eric