linux-kernel - Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 11:15:53 +0200
From:   Martin Kepplinger <martink@...teo.de>
To:     Leonard Crestez <leonard.crestez@....com>,
        Harinath Nampally <harinath922@...il.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY

On 2018-06-07 20:52, Leonard Crestez wrote:
> Interrupts are ignored if no event bit is set in the status status
> register and this breaks the buffer interface. No data is shown when
> running "iio_generic_buffer -n mma8451 -a" and interrupt counts go
> crazy.
> 
> Fix by not returning IRQ_NONE if DRDY is set.
> 
> Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle
> multiple events")
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@....com>

At least this does no harm to events. So if this solves your problem:

Acked-by: Martin Kepplinger <martink@...teo.de>

thanks,

                            martin

> 
> ---
>  drivers/iio/accel/mma8452.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Perhaps this whole early-exit check could be dropped? It is not clear
> how it helps.
> 
> If for some models we want to ignore unsupported events then maybe this
> should be checked for each individual bit. Instead of
> 
> if (src & MMA8452_INT_FF_MT) {
> 
> Check for:
> 
> if ((src & MMA8452_INT_FF_MT) && (data->chip_info->enabled_events & MMA8452_INT_FF_MT))
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 7a2da7f9d4dc..5485b35fe553 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -1032,11 +1032,11 @@ static irqreturn_t mma8452_interrupt(int irq, void *p)
>  
>  	src = i2c_smbus_read_byte_data(data->client, MMA8452_INT_SRC);
>  	if (src < 0)
>  		return IRQ_NONE;
>  
> -	if (!(src & data->chip_info->enabled_events))
> +	if (!(src & (data->chip_info->enabled_events | MMA8452_INT_DRDY)))
>  		return IRQ_NONE;
>  
>  	if (src & MMA8452_INT_DRDY) {
>  		iio_trigger_poll_chained(indio_dev->trig);
>  		ret = IRQ_HANDLED;
> 


Download attachment "pEpkey.asc" of type "application/pgp-keys" (1766 bytes)