linux-kernel - Re: [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 11:15:52 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Heinrich Schuchardt <xypron.glpk@....de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Vagrant Cascadian <vagrant@...ian.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Pierre-Hugues Husson <phh@....me>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399

Hi Heinrich,

Am Mittwoch, 20. Juni 2018, 07:59:34 CEST schrieb Heinrich Schuchardt:
> On 06/20/2018 01:21 AM, Heiko Stuebner wrote:
> > Am Donnerstag, 14. Juni 2018, 14:55:27 CEST schrieb Heiko Stuebner:
> >> Am Montag, 4. Juni 2018, 19:15:23 CEST schrieb Heinrich Schuchardt:
> >>> Without this patch the Firefly-RK3399 board boot process hangs after
> >>> these
> >>> 
> >>> lines:
> >>>    fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
> >>>    fan53555-reg: supplied by vcc_sys
> >>>    vcc1v8_s3: supplied by vcc_1v8
> >>> 
> >>> Blacklisting driver fan53555 allows booting.
> >>> 
> >>> The device tree uses a value of fcs,suspend-voltage-selector different
> >>> to
> >>> any other board.
> >>> 
> >>> Changing this setting to the usual value is sufficient to enable
> >>> booting.
> >>> 
> >>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> >> 
> >> applied for 4.19.
> > 
> > and dropped again.
> > 
> > Sadly it looks like the patch causes conflicts with at least one firefly
> > board in a kernelci lab. My own is currently not ready to use, so I cannot
> > look myself right now.
> > 
> > The issue kernelci people described sounded quite a lot like the one
> > in your commit message, so my current theory is that the
> > suspend-voltage-selector must in some form corespond to the
> > cpu_b_sleep_h gpio setting we're currently not handling at all, which
> > would therefore depend on how the bootloader sets this up.
>
> please, provide a link to the log displaying the issue and the contact
> who can provide the exact setup.
> 
> I have been testing with U-Boot as boot loader.

failing boot can be found on
https://kernelci.org/boot/id/5b2a053d59b514569079a872/

As this board is sitting in the "lab-baylibre-seattle", I guess
Kevin Hilman (Cc'ed now) is the one that can say a bit more about the
board setup.


The more interesting question would be how to make sure we don't
die with possible different bootloader versions. As I don't really thing 
"upgrade your bootloader" is an always valid option.


Heiko