linux-kernel - Re: [PATCH] iio:imu:adis: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Jul 2018 18:01:35 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio:imu:adis: Mark expected switch fall-throughs

On Tue, 3 Jul 2018 14:35:50 -0500
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to hopefully ignore!

Thanks,

Jonathan

> ---
>  drivers/iio/imu/adis.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index ad6f91d..c771ae6 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -81,9 +81,11 @@ int adis_write_reg(struct adis *adis, unsigned int reg,
>  		adis->tx[9] = (value >> 24) & 0xff;
>  		adis->tx[6] = ADIS_WRITE_REG(reg + 2);
>  		adis->tx[7] = (value >> 16) & 0xff;
> +		/* fall through */
>  	case 2:
>  		adis->tx[4] = ADIS_WRITE_REG(reg + 1);
>  		adis->tx[5] = (value >> 8) & 0xff;
> +		/* fall through */
>  	case 1:
>  		adis->tx[2] = ADIS_WRITE_REG(reg);
>  		adis->tx[3] = value & 0xff;
> @@ -167,6 +169,7 @@ int adis_read_reg(struct adis *adis, unsigned int reg,
>  		adis->tx[2] = ADIS_READ_REG(reg + 2);
>  		adis->tx[3] = 0;
>  		spi_message_add_tail(&xfers[1], &msg);
> +		/* fall through */
>  	case 2:
>  		adis->tx[4] = ADIS_READ_REG(reg);
>  		adis->tx[5] = 0;