[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2018 15:44:04 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Atish Patra <atish.patra@....com>, palmer@...ive.com,
linux-riscv@...ts.infradead.org, linux-pwm@...r.kernel.org,
linux-gpio@...r.kernel.org, linus.walleij@...aro.org,
robh+dt@...nel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, mark.rutland@....com
Subject: Re: [RFC 2/4] pwm: sifive: Add a driver for SiFive SoC PWM
On Wed, Oct 10, 2018 at 06:11:29AM -0700, Christoph Hellwig wrote:
[...]
> > +static struct platform_driver sifive_pwm_driver = {
> > + .probe = sifive_pwm_probe,
> > + .remove = sifive_pwm_remove,
> > + .driver = {
> > + .name = "pwm-sifivem",
> > + .of_match_table = of_match_ptr(sifive_pwm_of_match),
> > + },
> > +};
>
> What about using tabs to align this a little more nicely?
>
> static struct platform_driver sifive_pwm_driver = {
> .probe = sifive_pwm_probe,
> .remove = sifive_pwm_remove,
> .driver = {
> .name = "pwm-sifivem",
> .of_match_table = of_match_ptr(sifive_pwm_of_match),
> },
> };
I discourage people from doing that because down the road somebody might
add a field here that's longer than the alignment tabs and then either
it becomes ugly or they either have to realign everything to keep it
pretty. Single spaces around '=' don't have that problem if used
consistently.
Thierry
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists