linux-kernel - Re: [PATCH] ubifs: Fix WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 Oct 2018 09:21:40 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Richard Weinberger <richard@....at>, gregkh@...uxfoundation.org
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        dunlap@...radead.org
Subject: Re: [PATCH] ubifs: Fix WARN_ON logic in exit path

On 10/13/18 1:18 AM, Richard Weinberger wrote:
> ubifs_assert() is not WARN_ON(), so we have to invert
> the checks.
> Randy faced this warning with UBIFS being a module, since
> most users use UBIFS as builtin because UBIFS is the rootfs
> nobody noticed so far. :-(
> Including me.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 54169ddd382d ("ubifs: Turn two ubifs_assert() into a WARN_ON()")
> Signed-off-by: Richard Weinberger <richard@....at>

Thanks.  Works for me.

> ---
> Greg,
> 
> can you please take this patch directly?
> It fixes a brown paper bug which was introduced in rc1, I'd like to avoid
> having it in a release and going the -stable path.
> 
> Thanks,
> //richard
> ---
>  fs/ubifs/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index bf000c8aeffb..fec62e9dfbe6 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2337,8 +2337,8 @@ late_initcall(ubifs_init);
>  
>  static void __exit ubifs_exit(void)
>  {
> -	WARN_ON(list_empty(&ubifs_infos));
> -	WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
> +	WARN_ON(!list_empty(&ubifs_infos));
> +	WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) != 0);
>  
>  	dbg_debugfs_exit();
>  	ubifs_compressors_exit();
> 


-- 
~Randy