linux-kernel - Re: [PATCH] usb: dwc3: don't log probe deferrals; but do log other error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Nov 2018 11:00:18 +0100
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: don't log probe deferrals; but do log other
 error codes

Hi,
Missatge de Brian Norris <briannorris@...omium.org> del dia dc., 7 de
nov. 2018 a les 21:42:
>
> It's not very useful to repeat a bunch of probe deferral errors. And
> it's also not very useful to log "failed" without telling the error
> code.
>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
>  drivers/usb/dwc3/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 88c80fcc39f5..1ef346ba6a02 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1482,7 +1482,8 @@ static int dwc3_probe(struct platform_device *pdev)
>
>         ret = dwc3_core_init(dwc);
>         if (ret) {
> -               dev_err(dev, "failed to initialize core\n");
> +               if (ret != -EPROBE_DEFER)
> +                       dev_err(dev, "failed to initialize core: %d\n", ret);
>                 goto err4;
>         }
>
> --
> 2.19.1.930.g4563a0d9d0-goog
>

fwiw this removes an annoying boot message that appears on every boot
and also was confusing some people that thought that their usb didn't
work.

Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>