linux-kernel - Re: [PATCH v1 1/1] dt-bindings: firmware: qcom: scm: Updating VMID list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 03:21:39 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Gokul krishna Krishnakumar <quic_gokukris@...cinc.com>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Satya Durga Srinivasu Prabhala <quic_satyap@...cinc.com>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Elliot Berman <quic_eberman@...cinc.com>,
        Guru Das Srinagesh <quic_gurus@...cinc.com>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Melody Olvera <quic_molvera@...cinc.com>
Subject: Re: [PATCH v1 1/1] dt-bindings: firmware: qcom: scm: Updating VMID list

On Wed, 29 Mar 2023 at 00:47, Gokul krishna Krishnakumar
<quic_gokukris@...cinc.com> wrote:
>
> Adding the full list of VMID's, which are used by different clients to
> pass to the secure world.
>
> Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@...cinc.com>
> ---
>  include/dt-bindings/firmware/qcom,scm.h | 31 +++++++++++++++++++++----
>  1 file changed, 26 insertions(+), 5 deletions(-)
>
> diff --git a/include/dt-bindings/firmware/qcom,scm.h b/include/dt-bindings/firmware/qcom,scm.h
> index 1a4e68fa0744..703b6f1750f4 100644
> --- a/include/dt-bindings/firmware/qcom,scm.h
> +++ b/include/dt-bindings/firmware/qcom,scm.h
> @@ -2,15 +2,36 @@
>  /*
>   * Copyright (c) 2010-2015, 2018-2019 The Linux Foundation. All rights reserved.
>   * Copyright (C) 2015 Linaro Ltd.
> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
>   */
>
>  #ifndef _DT_BINDINGS_FIRMWARE_QCOM_SCM_H
>  #define _DT_BINDINGS_FIRMWARE_QCOM_SCM_H
>
> -#define QCOM_SCM_VMID_HLOS             0x3
> -#define QCOM_SCM_VMID_MSS_MSA          0xF
> -#define QCOM_SCM_VMID_WLAN             0x18
> -#define QCOM_SCM_VMID_WLAN_CE          0x19
> -#define QCOM_SCM_VMID_NAV              0x2B

These IDs were not changed, but your patch doesn't make that obvious.
Please fix the alignment so that old IDs are intact.

> +#define QCOM_SCM_VMID_TZ                       0x1
> +#define QCOM_SCM_VMID_HLOS                     0x3
> +#define QCOM_SCM_VMID_CP_TOUCH                 0x8
> +#define QCOM_SCM_VMID_CP_BITSTREAM             0x9
> +#define QCOM_SCM_VMID_CP_PIXEL                 0xA
> +#define QCOM_SCM_VMID_CP_NON_PIXEL             0xB
> +#define QCOM_SCM_VMID_CP_CAMERA                        0xD
> +#define QCOM_SCM_VMID_HLOS_FREE                        0xE
> +#define QCOM_SCM_VMID_MSS_MSA                  0xF
> +#define QCOM_SCM_VMID_MSS_NONMSA               0x10
> +#define QCOM_SCM_VMID_CP_SEC_DISPLAY           0x11
> +#define QCOM_SCM_VMID_CP_APP                   0x12
> +#define QCOM_SCM_VMID_LPASS                    0x16
> +#define QCOM_SCM_VMID_WLAN                     0x18
> +#define QCOM_SCM_VMID_WLAN_CE                  0x19
> +#define QCOM_SCM_VMID_CP_SPSS_SP               0x1A
> +#define QCOM_SCM_VMID_CP_CAMERA_PREVIEW                0x1D
> +#define QCOM_SCM_VMID_CDSP                     0x1E
> +#define QCOM_SCM_VMID_CP_SPSS_SP_SHARED                0x22
> +#define QCOM_SCM_VMID_CP_SPSS_HLOS_SHARED      0x24
> +#define QCOM_SCM_VMID_ADSP_HEAP                        0x25
> +#define QCOM_SCM_VMID_CP_CDSP                  0x2A
> +#define QCOM_SCM_VMID_NAV                      0x2B
> +#define QCOM_SCM_VMID_TVM                      0x2D
> +#define QCOM_SCM_VMID_OEMVM                    0x31
>
>  #endif
> --
> 2.39.2
>


-- 
With best wishes
Dmitry