netdev - Re: [PATCH 7/11][TG3]: Eliminate the TG3_FLAG_5701_REG_WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 May 2007 10:46:12 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Michael Chan <mchan@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 7/11][TG3]: Eliminate the TG3_FLAG_5701_REG_WRITE_BUG flag.

On Fri, May 04, 2007 at 05:54:17PM -0700, Michael Chan wrote:
> +	else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701 ||
> +		 ((tp->tg3_flags2 & TG3_FLG2_PCI_EXPRESS) &&
> +		  tp->pci_chip_rev_id == CHIPREV_ID_5750_A0)) {
> +		/* Back to back register writes can cause problems on this chip,
> +		 * the workaround is to read back all reg writes except those to
> +		 * mailbox regs.  See tg3_write_indirect_reg32().
> +		 *
> +		 * PCI Express 5750_A0 rev chips need this workaround too.
> +		 */
>  		tp->write32 = tg3_write_flush_reg32;

This comment is a little odd now.  What about

		/*
		 * Back to back register writes can cause problems on these
		 * chips, the workaround is to read back all reg writes
		 * except those to mailbox regs.
		 *
		 * See tg3_write_indirect_reg32().
		 */

instead?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html