netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jul 2007 08:01:14 -0400
From:	jamal <hadi@...erus.ca>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4

On Wed, 2007-25-07 at 01:31 -0700, David Miller wrote:
> We're getting there, slowly...
> 
> 1) netif_napi_init() is added, the workqueue/requeue stuff
>    as discussed is not needed so you won't see that here
..
....
> Another thing that's really apparent now is all the wacky
> napi->weight values various drivers use.  Just grep for
> netif_napi_init() in the patch or a patched tree to see what
> I mean.  So much of it doesn't make any sense and I'm tempted
> to just remove the argument and make everyone use 32 or 64
> or something like that :-)  Or, default to some value across
> the board, and let drivers override that on a case by case
> basis with a BIG FAT COMMENT above the override describing
> why the different value is being used and precisely what
> tests were performed to validate that different value.

Sounds reasonable.
32-64 for Gige seemed to work well as i recall. 10/100 was around 16.
But that shouldnt matter i think: because the poll from the core is
based on Varghese's DRR, it probably will be fine if you just gave all
the same value and the "deficit" part will kick in when needed. Some
testing maybe required but theoretically i dont see a problem. 

BTW: The current kernel code has a "bug" - where if a driver
forgot to set its weight it would be indeterminate, so even for this
reason it will be a good idea to enforce a default.

Sorry, havent been following the thread - thanks for CCing me, will try
to catch up at some point.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html