[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2007 18:30:19 +0200
From: Michael Buesch <mb@...sch.de>
To: Roland Dreier <rdreier@...co.com>
Cc: Andi Kleen <andi@...stfloor.org>, Jeff Garzik <jeff@...zik.org>,
ggrundstrom@...effect.com, ewg@...ts.openfabrics.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines
On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote:
> > But there are indeed a few cases that look wrong.
>
> yes...
>
> > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target);
>
> eg this almost certainly wants to be
>
> writel(swab32(val), target);
>
> or something equivalent like
>
> __raw_writel(cpu_to_be32(val), target);
> /* plus some suffficent memory ordering */
>
> - R.
>
>
certainly, yes.
Most likely the __raw_writel variant is portable, but I am not
sure. Anybody sure?
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists