netdev - Re: [PATCH 2/14] nes: device structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2007 12:33:24 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Michael Buesch <mb@...sch.de>
CC:	Roland Dreier <rdreier@...co.com>,
	Andi Kleen <andi@...stfloor.org>, ggrundstrom@...effect.com,
	ewg@...ts.openfabrics.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines

Michael Buesch wrote:
> On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote:
>>  > But there are indeed a few cases that look wrong.
>>
>> yes...
>>
>>  > arch/x86_64/kernel/pci-calgary.c:       writel(cpu_to_be32(val), target);
>>
>> eg this almost certainly wants to be
>>
>> 	writel(swab32(val), target);
>>
>> or something equivalent like
>>
>> 	__raw_writel(cpu_to_be32(val), target);
>> 	/* plus some suffficent memory ordering */
>>
>>  - R.
>>
>>
> 
> certainly, yes.
> Most likely the __raw_writel variant is portable, but I am not
> sure. Anybody sure?

Yes, it's portable.  You must however be aware of the guarantees that 
writel() provides and __raw_writel() does not:  no barriers or flushes, 
no endian conversions, no ordering constraints, ...  Probably a few more 
details I'm forgetting too :)

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html