netdev - Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 17:50:42 -0400
From:	"Luis R. Rodriguez" <mcgrof@...il.com>
To:	"Larry Finger" <larry.finger@...inger.net>
Cc:	"Johannes Berg" <johannes@...solutions.net>,
	"Christoph Hellwig" <hch@...radead.org>,
	"Jiri Slaby" <jirislaby@...il.com>, linville@...driver.com,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On 8/28/07, Larry Finger <larry.finger@...inger.net> wrote:
> Johannes Berg wrote:
> > On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote:
> >> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote:
> >>> -ath5k-objs         = ath5k_base.o ath5k_hw.o ath5k_regdom.o
> >>> +ath5k-objs         = ath5k_base.o ath5k_hw.o ath5k_regdom.o \
> >>> +                     ath5k_hw_phy.o ath5k_hw_inivals.o
> >> And while I'm at nitpicking :)
> >>
> >> ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
> >> most drivers and ath5k_hw_inivals.o mights aswell be something like
> >> ath5k_init.o
> >
> > While we're at names... I personally much prefer a new directory ath5k
> > and then ath5k/hw.c etc. but it seems I'm pretty alone in that. But here
> > we already have at least four files now.
>
> I agree with you. If a wireless driver takes more than one .c and one .h file, it belongs in its own
> directory, and the file names stripped of any driver prefix. Not only are the file names simpler,
> but Makefile and Kconfig in wireless benefits.

NACK, I don't agree with this patch. The ath5k_regdom.* files will be
gone soon anyway and don't see the reason to split the files even
more. Now iwlwifi... -- that could is own directory IMHO :)

  Luis
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html