netdev - Re: [PATCH] sky2: sky2 FE+ receive status workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Sep 2007 16:23:29 +0100
From:	Jochen Voss <voss@...huhn.de>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: sky2 FE+ receive status workaround

Hi,

On Thu, Sep 27, 2007 at 06:58:07AM -0700, Stephen Hemminger wrote:
> On Thu, 27 Sep 2007 09:14:11 +0100 Jochen Voß <voss@...huhn.de> wrote:
> > On 27 Sep 2007, at 01:58, Stephen Hemminger wrote:
> > > +	/* This chip has hardware problems that generates bogus status.
> > > +	 * So do only marginal checking and expect higher level protocols
> > > +	 * to handle crap frames.
> > > +	 */
> > > +	if (sky2->hw->chip_id == CHIP_ID_YUKON_FE_P &&
> > > +	    sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0 &&
> > > +	    length != count)
> > > +		goto okay;
> > 
> > Shouldn't the condition be "length == count"?
> 
> No, the code is correct as is.  Basically if length == count, then
> the status field is correct, and the driver can go ahead and use it.
> If length != count, then the status is bogus but the data is okay.

Oh, I see.  Thanks for the explanation.

All the best,
Jochen
-- 
http://seehuhn.de/

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)