netdev - Re: [PATCH] NET : Corrects a bug in ip_rt_acct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Nov 2007 02:32:08 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : Corrects a bug in ip_rt_acct_read()

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 16 Nov 2007 11:25:19 +0100

> [PATCH] NET : Corrects a bug in ip_rt_acct_read()
> 
> It seems that stats of cpu 0 are counted twice, since 
> for_each_possible_cpu() is looping on all possible cpus,
> including 0
> 
> Before percpu conversion of ip_rt_acct, we should also remove
> the assumption that CPU 0 is online (or even possible)
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied, good catch Eric.

To make things easier for you I've applied it to both
net-2.6 and net-2.6.25

It seems like the code was trying to avoid that initial
memset, grabbing the first cpu explicitly and then copying
along the way.  But the loop iterator wasn't adjusted
correctly and of course the zero-cpu-assumption you
noticed as well plays into this :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html