netdev - Re: net_rx_action/NAPI oops [PATCH]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Nov 2007 18:22:56 +0100
From:	Robert Olsson <Robert.Olsson@...a.slu.se>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Robert Olsson <Robert.Olsson@...a.slu.se>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: net_rx_action/NAPI oops [PATCH]



 No it doesn't. besides napi_disable and napi_synchronize are identical. 
 I was trying to disarm interrupts this way too. 

 The patch I did send yesterday is the only cure so-far but I don't if 
 it's 100% bullet proof either.

 I was stress-testing it patch but ran into new problems...(scheduling)
 
 Cheers.
					--ro


Stephen Hemminger writes:
 > Would this fix it?
 > 
 > --- a/drivers/net/e1000/e1000_main.c	2007-11-15 21:13:12.000000000 -0800
 > +++ b/drivers/net/e1000/e1000_main.c	2007-11-28 08:37:03.000000000 -0800
 > @@ -630,10 +630,10 @@ e1000_down(struct e1000_adapter *adapter
 >  	 * reschedule our watchdog timer */
 >  	set_bit(__E1000_DOWN, &adapter->flags);
 >  
 > +	e1000_irq_disable(adapter);
 >  #ifdef CONFIG_E1000_NAPI
 > -	napi_disable(&adapter->napi);
 > +	napi_synchronize(&adapter->napi);
 >  #endif
 > -	e1000_irq_disable(adapter);
 >  
 >  	del_timer_sync(&adapter->tx_fifo_stall_timer);
 >  	del_timer_sync(&adapter->watchdog_timer);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html