netdev - Re: [PATCH] smsc9420: SMSC LAN9420 10/100 PCI ethernet adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2008 23:02:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	steve.glendinning@...c.com
Cc:	netdev@...r.kernel.org, vlad.lyalikov@...c.com,
	ian.saturley@...c.com
Subject: Re: [PATCH] smsc9420: SMSC LAN9420 10/100 PCI ethernet adapter

From: Steve Glendinning <steve.glendinning@...c.com>
Date: Tue,  9 Dec 2008 14:57:43 +0000

> +uint debug_mode = (DBG_MCAST | DBG_WARNING | DBG_INIT | DBG_CLOSE | DBG_LINK |
> +	DBG_PWR);
> +module_param(debug_mode, uint, 0);
> +MODULE_PARM_DESC(debug_mode, "enables debugging messages");

We have a standard way to do this, and standard bitmask values,
and an ethtool call to set this.  Please use it.

Look at how niu_debug is used in drivers/net/niu.c, functions
like netif_msg_init(), and assosciated interfaces.

There really is no need for this home-grown stuff :-)

Otherwise this driver looks pretty good.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html