netdev - Re: [Patch] Micrel KS8695 integrated ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2008 23:05:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dsilvers@...tec.co.uk
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [Patch] Micrel KS8695 integrated ethernet driver

From: Daniel Silverstone <dsilvers@...tec.co.uk>
Date: Tue, 09 Dec 2008 17:30:09 +0000

> +			mapping = dma_map_single(ksp->dev, skb->data,
> +						 MAX_RXBUF_SIZE,
> +						 DMA_FROM_DEVICE);
> +			if (!mapping) {

There is a proper way to check for DMA mapping failures.
Comparing against zero is not it :-)

> +	ksp->tx_buffers[buff_n].dma_ptr = dma_map_single(
> +		ksp->dev, skb->data, skb->len, DMA_TO_DEVICE);
> +	if (!ksp->tx_buffers[buff_n].dma_ptr) {

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html